>>> On 08.05.15 at 16:34, <roger....@citrix.com> wrote:
> @@ -3668,21 +3671,19 @@ int shadow_track_dirty_vram(struct domain *d,
> if ( map_sl1p )
> sh_unmap_domain_page(map_sl1p);
>
> - rc = -EFAULT;
> - if ( copy_to_guest(dirty_bitmap, dirty_vram->dirty_bitmap,
> dirty_size) == 0 ) {
> - memset(dirty_vram->dirty_bitmap, 0, dirty_size);
> - if (dirty_vram->last_dirty + SECONDS(2) < NOW())
> + memcpy(dirty_bitmap, dirty_vram->dirty_bitmap, dirty_size);
> + memset(dirty_vram->dirty_bitmap, 0, dirty_size);
This is certainly a behavioral change; I'm only uncertain whether it's
acceptable. Previously the memset() was done only when the copying
to guest memory succeeded, while now it happens unconditionally.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
