0 is a valid physical address and dt_device_get_address would return an error if a problem during the retrieving happen.
Signed-off-by: Julien Grall <julien.gr...@citrix.com> --- xen/arch/arm/gic-v2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 99d1dfd..de16fc7 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -686,19 +686,19 @@ static int __init gicv2_init(void) const struct dt_device_node *node = gicv2_info.node; res = dt_device_get_address(node, 0, &gicv2.dbase, NULL); - if ( res || !gicv2.dbase ) + if ( res ) panic("GICv2: Cannot find a valid address for the distributor"); res = dt_device_get_address(node, 1, &gicv2.cbase, NULL); - if ( res || !gicv2.cbase ) + if ( res ) panic("GICv2: Cannot find a valid address for the CPU"); res = dt_device_get_address(node, 2, &gicv2.hbase, NULL); - if ( res || !gicv2.hbase ) + if ( res ) panic("GICv2: Cannot find a valid address for the hypervisor"); res = dt_device_get_address(node, 3, &gicv2.vbase, NULL); - if ( res || !gicv2.vbase ) + if ( res ) panic("GICv2: Cannot find a valid address for the virtual CPU"); res = platform_get_irq(node, 0); -- 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel