El 07/05/15 a les 17.10, Jan Beulich ha escrit: >>>> On 07.05.15 at 16:54, <roger....@citrix.com> wrote: >> Since a PVH hardware domain has access to the physical hardware create a >> custom more permissive IO bitmap. The permissions set on the bitmap are >> populated based on the contents of the ioports rangeset. >> >> Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > Reviewed-by: Jan Beulich <jbeul...@suse.com> > with one minor remark:
Thanks. >> --- a/xen/arch/x86/hvm/vmx/vmcs.c >> +++ b/xen/arch/x86/hvm/vmx/vmcs.c >> @@ -1032,8 +1032,9 @@ static int construct_vmcs(struct vcpu *v) >> } >> >> /* I/O access bitmap. */ >> - __vmwrite(IO_BITMAP_A, virt_to_maddr((char *)hvm_io_bitmap + 0)); >> - __vmwrite(IO_BITMAP_B, virt_to_maddr((char *)hvm_io_bitmap + >> PAGE_SIZE)); >> + __vmwrite(IO_BITMAP_A, virt_to_maddr(d->arch.hvm_domain.io_bitmap)); >> + __vmwrite(IO_BITMAP_B, virt_to_maddr(d->arch.hvm_domain.io_bitmap + >> + PAGE_SIZE / BYTES_PER_LONG)); > > Why not > > __vmwrite(IO_BITMAP_B, virt_to_maddr(d->arch.hvm_domain.io_bitmap) + > PAGE_SIZE); > > ? (If you agree I can change this while committing.) Sure, please go ahead. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
