> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 06 May 2015 13:27 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: Re: [PATCH v4 1/3] x86/hvm: give HVMOP_set_param and > HVMOP_get_param their own functions > > >>> On 05.05.15 at 17:47, <paul.durr...@citrix.com> wrote: > > The level of switch nesting in those ops is getting unreadable. Giving > > them their own functions does introduce some code duplication in the > > the pre-op checks but the overall result is easier to follow. > > > > This patch is code movement (including style fixes). There is no > > functional change. > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > Cc: Keir Fraser <k...@xen.org> > > Cc: Jan Beulich <jbeul...@suse.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > > --- > > xen/arch/x86/hvm/hvm.c | 556 +++++++++++++++++++++++++----------- > ------------ > > 1 file changed, 294 insertions(+), 262 deletions(-) > > This doesn't apply to current staging (conflicts with at least > 0a246b41cab40e3409c361c1ef6c1fcfaba5fd1f). >
Ok. I'll rebase and resend the series. Paul > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
