On Fri, 2015-05-01 at 16:02 +0100, Ian Jackson wrote:
> This makes reading the scoreboard considerably easier.
>
> We abuse the local variable @worst slight, pushing the extra info we
^ly
> @@ -993,9 +995,13 @@ END
> next if $this[1] < $worst[1];
> next if $this[1] == $worst[1] && $ei->{Step}{status} ne 'pass';
> @worst=@this;
> + push @worst,
> + encode_entities("$ei->{Step}{stepno}. $ei->{Step}{testid}");
> }
> - print H "<td ",$worst[2],">",$worst[0],"</td>";
> + push @worstrow1, "<td ",$worst[2],">",$worst[3],"</td>";
> + push @worstrow2, "<td ",$worst[2],">",$worst[0],"</td>";
> }
> + print H "\n", @worstrow1, "\n<tr>\n", @worstrow2;
Does this need a </tr> in the middle?
I think there was likely no </tr> in the old code either, and I suppose
web standards being what they are <tr>...<tr>...<tr>... probably works.
That being the case you could reasonably defer shaving this yakk for
another time.
> print H "\n";
> # Create a gutter row after the headers.
> print H "<tr><td> </td></tr>\n";
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
