On 23/04/15 16:46, Paul Durrant wrote: > hvm_free_ioreq_gmfn has the sense of the ioreq_gmfn mask inverted; it > needs to set a bit to release the gmfn, not clear it. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Keir Fraser <k...@xen.org> > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>
s/mask/free_mask/ ? For the change itself, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > xen/arch/x86/hvm/hvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index bfde380..f840175 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -496,7 +496,7 @@ static void hvm_free_ioreq_gmfn(struct domain *d, > unsigned long gmfn) > { > unsigned int i = gmfn - d->arch.hvm_domain.ioreq_gmfn.base; > > - clear_bit(i, &d->arch.hvm_domain.ioreq_gmfn.mask); > + set_bit(i, &d->arch.hvm_domain.ioreq_gmfn.mask); > } > > static void hvm_unmap_ioreq_page(struct hvm_ioreq_server *s, bool_t buf) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel