On Tue, 2015-04-21 at 14:28 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in
> TestSupport.pm for nested test"):
> > On Tue, 2015-04-21 at 13:33 +0100, Ian Jackson wrote:
> > > It seems to be copying information from runvars into the in-memory
> > > data structure for host properties. But host properties are (by
> > > definition) matters of (fixed) configuration, not runtime definition.
> >
> > Remember that here the "host" is actual an L1 virtual machine, whose IP
> > is not fixed (since it mac address isn't).
>
> Indeed.
>
> > I don't know if that affects your opinion at all?
>
> No, it doesn't. I agree that the IP address should be dynamically
> figured out, and passing it through a runvar is fine.
>
> I'm only objecting to the involvement of the host property machinery.
I'm afraid I'm not 100% sure I understand, but do you just mean that
longtao should assign to $ho->{Ip} directly within selecthost instead of
using $setprop to set the IpAddr hostprop and therefore indirectly
->{Ip}?
IOW the existing code in selecthost which looks up the IpAddr host prop
into $ho->{IpStatic} and then into $ho->{Ip} should prefer the runvar to
the host db if it is set?
BTW, what is the difference between ->{Ip} and ->{IpStatic} and should
the runvar be reflected in both or just in ->{Ip}?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
