On 26/03/15 12:16, Bob Liu wrote: > There are several place using gnttab async unmap and wait for > completion, so move the common code to a function > gnttab_unmap_refs_async_wait_completion(). > [...] > + > +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* > item)
This name is a bit wordy. Can you rename it to: gnttab_unmap_refs_sync() gnttab_unmap_refs_wait(), or gnttab_unmap_refs_safe(). (I can't decide which is the best name.). David _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel