Hi Ian, On 31/03/15 11:55, Ian Campbell wrote: > On Thu, 2015-03-19 at 19:29 +0000, Julien Grall wrote: >> Introduce spi_to_pending in order retrieve the irq_pending structure for >> a specific SPI. >> >> It's not possible to re-use irq_to_pending because it's required a VCPU > > "it requires" > >> and some call of the new function may during domain destruction after >> the VCPUs are freed. >> >> Signed-off-by: Julien Grall <julien.gr...@linaro.org> > > Acked-by: Ian Campbell <ian.campb...@citrix.com>
Thanks. > Although given the name I would expect it to take an spi (i.e. -32) not > an irq. I can't think of a better name though and perhaps that just > makes things harder for the caller.. It depends if you think relative or absolute. In this case, the absolute value is easier to use. FWIW, we already have SPI-specific function using absolute value. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
