Ian Campbell wrote: > On Wed, 2015-03-25 at 14:08 -0600, Jim Fehlig wrote: > >> A destroy operation can take considerable time on large memory >> domains due to scrubbing the domain' memory. The operation is >> running in the context of a job, so unlocking the domain and >> allowing query operations is safe. >> >> Signed-off-by: Jim Fehlig <jfeh...@suse.com> >> > > I don't really know enough about the libvirt job/obj locking to comment > on the previous patches or that aspect of this one, but in general the > idea of dropping the lock before calling libxl_destroy seems reasonable > to me. > > In principal you could use the async stuff (the final NULL to the call), > but you'd still be wanting to drop the lock for that period, so it's not > clear it's any better from your PoV. >
I tried the async approach as well, but in the end decided it was no better. In case you're interested, I pushed the async variant to libxl-dom-destroy-async branch in my github fork https://github.com/jfehlig/libvirt Regards, Jim _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
