On Tue, Mar 17, 2015 at 09:30:57AM -0600, Jim Fehlig wrote: > From: Ian Jackson <ian.jack...@eu.citrix.com> > > From: Ian Jackson <ian.jack...@eu.citrix.com> > > When domain_death_xswatch_callback needed a further call to > xc_domain_getinfolist it would restart it with the last domain it > found rather than the first one it wants. > > If it only wants one it will also only ask for one domain. The result > would then be that it gets the previous domain again (ie, the previous > one to the one it wants), which still doesn't reveal the answer to the > question, and it would therefore loop again. > > It's completely unclear to me why I thought it was a good idea to > start the xc_domain_getinfolist with the last domain previously found > rather than the first one left un-confirmed. The code has been that > way since it was introduced. > > Instead, start each xc_domain_getinfolist at the next domain whose > status we need to check. > > We also need to move the test for !evg into the loop, we now need evg > to compute the arguments to getinfolist. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > Reported-by: Jim Fehlig <jfeh...@suse.com> > Reviewed-by: Jim Fehlig <jfeh...@suse.com> > Tested-by: Jim Fehlig <jfeh...@suse.com>
Acked-by: Wei Liu <wei.l...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
