>>> On 16.03.15 at 18:04, <dario.faggi...@citrix.com> wrote: > --- a/xen/common/sched_rt.c > +++ b/xen/common/sched_rt.c > @@ -264,18 +264,17 @@ rt_dump(const struct scheduler *ops) > struct list_head *iter_sdom, *iter_svc, *runq, *depletedq, *iter; > struct rt_private *prv = rt_priv(ops); > struct rt_vcpu *svc; > - cpumask_t *online; > struct rt_dom *sdom; > unsigned long flags; > > - ASSERT(!list_empty(&prv->sdom)); > + spin_lock_irqsave(&prv->lock, flags); > + > + if (list_empty(&prv->sdom))
Coding style. > + goto out; > > - sdom = list_entry(prv->sdom.next, struct rt_dom, sdom_elem); > - online = cpupool_scheduler_cpumask(sdom->dom->cpupool); Unrelated change (together with the variable deletion above). I'm fine for this to stay here, but it should at least be mentioned in the description so that future archeologists don't wonder about the connection to the actual issue fixed here. > @@ -303,6 +302,7 @@ rt_dump(const struct scheduler *ops) > } > } > > +out: Labels should be indented by at least one space. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
