On 02/27/2015 04:51 PM, Dario Faggioli wrote: > for events that are specific to Credit2 (as it happens > for Credit1 already). > > Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com> > Cc: George Dunlap <george.dun...@eu.citrix.com> > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Keir Fraser <k...@xen.org> > Acked-by: Jan Beulich <jbeul...@suse.com> > --- > Changes from v1: > * fixed the repeated typo in perfc_defn.h, as requested > during review. > --- > xen/common/sched_credit2.c | 23 +++++++++++++++++++++++ > xen/include/xen/perfc_defn.h | 15 ++++++++++++++- > 2 files changed, 37 insertions(+), 1 deletion(-) > > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > index c0f7452..bf0d651 100644 > --- a/xen/common/sched_credit2.c > +++ b/xen/common/sched_credit2.c > @@ -654,6 +654,8 @@ static void reset_credit(const struct scheduler *ops, int > cpu, s_time_t now, > } > } > > + SCHED_STAT_CRANK(credit_reset); > +
Is this one actually useful? Anyway, it's the only one I could find that I had that question for, so not a big deal to leave it in. :-) One more minor thing: > diff --git a/xen/include/xen/perfc_defn.h b/xen/include/xen/perfc_defn.h > index f754331..526002d 100644 > --- a/xen/include/xen/perfc_defn.h > +++ b/xen/include/xen/perfc_defn.h > @@ -28,10 +28,10 @@ PERFCOUNTER(vcpu_wake_runnable, "sched: > vcpu_wake_runnable") > PERFCOUNTER(vcpu_wake_not_runnable, "sched: vcpu_wake_not_runnable") > PERFCOUNTER(tickle_idlers_none, "sched: tickle_idlers_none") > PERFCOUNTER(tickle_idlers_some, "sched: tickle_idlers_some") > +PERFCOUNTER(vcpu_check, "sched: vcpu_check") > > /* credit specific counters */ > PERFCOUNTER(delay_ms, "csched: delay") > -PERFCOUNTER(vcpu_check, "csched: vcpu_check") You forgot to mention making this one generic in your patch description. But that's probably not worth a re-spin either. :-) Acked-by: George Dunlap <george.dun...@eu.citrix.com> -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
