On 16/03/15 10:12, Stefano Stabellini wrote: >>> BTW this is not even a copy from Linux. You replaced all the hard tab by >>> space... >> >> Yes, I replaced tabs. Whats the ways of copying linux driver to Xen. >> Should we keep and maintain coding style as well? > > If it is the Linux driver you are importing, then it might be worth > trying to keep it as close to the original as possible so that it won't > be too hard to update in the future. Like Julien has done for the SMMU > driver.
Given all the changes made in the driver afterwards, I don't think it would possible to backport patch from Linux. But at least it would help to see the difference during the review of this series. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
