On Mon, 2015-02-09 at 11:09 +0000, Wei Liu wrote:
> +sub saverestore_check ($) {
> + my ($self) = @_;
> + my $ho = $self->{Host};
> + my $help = target_cmd_output_root($ho, $self->{_Command}." help");
> + my $rc = ($help =~ m/^\s*save/m) ? 0 : 1;
> + logm("rc=$rc");
> + return $rc;
You could refactor this and the migration_check into a more generic
"check for a named command" helper.
And you could prepare the libvirt one for the same once migration gets
added I suppose.
Everything else looks OK to me.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
