Hi Ian,
On 20/02/15 17:17, Ian Campbell wrote:
>> + /* TODO: Do we need to check is_dying? Mostly to protect against
>> + * hypercall trying to passthrough a device while we are
>> + * dying.
>
> FWIW the PCI case appears not to care...
There is one place in XEN_DOMCTL_assign_device...
Although I don't understand much the usage of is_dying.
>> + */
>> +
>> + switch ( domctl->cmd )
>> + {
>> + case XEN_DOMCTL_assign_device:
>> + ret = -ENOSYS;
>> + if ( domctl->u.assign_device.dev != XEN_DOMCTL_DEV_DT )
>> + break;
>
> You added something similar to iommu_do_pci_domctl, would it not be
> preferable for the caller to switch on domctl->u.assign_device.dev and
> call the correct iommu_do_*_domctl?
I though about it. It would require to stub iommu_do_*_domctl. So I
preferred to chose the current solution.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
