On Tue, Mar 10, 2015 at 06:42:30AM +0000, Liu, SongtaoX wrote: > > -----Original Message----- > > From: xen-devel-boun...@lists.xen.org > > [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Ian Campbell > > Sent: Tuesday, March 03, 2015 1:00 AM > > To: Wei Liu > > Cc: Samuel Thibault; Stefano Stabellini; Ian Jackson; > > xen-devel@lists.xen.org > > Subject: Re: [Xen-devel] [PATCH v2] stubdom: fix make clean and distclean > > on a > > freshly cloned tree > > > > On Mon, 2015-03-02 at 15:05 +0000, Wei Liu wrote: > > > Clean and distclean targets need not depend on existence of the > > > mini-os tree. Don't check for mini-os and don't try to blindly include > > > mini-os's Config.mk when doing clean and distclean. > > > > > > Note that one subtle issue is that $(XEN_ROOT)/Config.mk tries to > > > include $(XEN_ROOT)/config/$(XEN_OS).mk. In stubdom's case XEN_OS is > > > "MiniOS". Then $(XEN_ROOT)/config/MiniOS.mk tries to include mini-os's > > > Config.mk. > > > > > > Since clean and distclean don't enforce existence of mini-os tree, > > > don't include $(XEN_ROOT)/Config.mk to avoid getting error due to the > > > aforementioned issue. > > > > > > Reported-by: Sander Eikelenboom <li...@eikelenboom.it> > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > > Cc: Ian Campbell <ian.campb...@citrix.com> > > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > > > Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > > > Cc: Samuel Thibault <samuel.thiba...@ens-lyon.org> > > > > Acked + applied, thanks. > > > When building pv-grub, error occurred with " ld: warning: app.lds contains > output sections; did you forget -T? > ld: cannot find -lxenguest " > > Building pv-grub steps(after building xen and tools): > "cd xen > make mini-os-dir > cd studom > ./configure > make pv-grub" > > There were some errors in mini-os.git/Makefile introduced by commit 55f7cd74. > 1. The commit had deleted the XEN_ROOT variable in Makefile, bug it still > used it; > 2. And XEN_TARGET_ARCH was blank for the above steps; it will report " ld: > cannot find -lxenguest "; > 3. it lacks a "-T" option, it would report the warning " ld: warning: app.lds > contains output sections; did you forget -T?". > > Following patch may work around this issue. >
Thanks for reporting. The patch below is not correct. I will submit a patch series to fix these problems and CC you. We. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
