>>> On 01.11.17 at 15:03, <julien.gr...@linaro.org> wrote: > Most of the users of page_to_mfn and mfn_to_page are either overriding > the macros to make them work with mfn_t or use mfn_x/_mfn becaue the rest > of the function use mfn_t. > > So I think it is time to make __page_to_mfn and __mfn_to_page using typesafe > MFN.
I have to admit that I still find the overall goal confusing: Afaict the double-underscore-prefixed versions exist only to allow easily overriding the non-prefixed ones. Hence the first and foremost goal ought to be to convert everyone to using the non-prefixed versions. Files wanting to avoid the typed forms could then continue to use / be switched to the prefixed ones. What you're doing here is producing a mess: The prefixed versions should never have been touched in the first place. And iirc this was discussed before, with the suggestion to use overrides (for the non-prefixed versions) to limit overall patch size. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
