On 11/03/17 15:40 +0800, Chao Peng wrote:
>
> > +/*
> > + * Interface for NVDIMM management.
> > + */
> > +
> > +struct xen_sysctl_nvdimm_op {
> > + uint32_t cmd; /* IN: XEN_SYSCTL_nvdimm_*; none is implemented
> > yet. */
> > + uint32_t pad; /* IN: Always zero. */
>
> If alignment is the only concern, then err can be moved to here.
>
> If it's designed for future and does not get used now, then it's better
> to check its value explicitly.
>
I'll move 'err' to the position of 'pad'.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
