On Thu, Oct 19, 2017 at 10:36:33AM +0800, Zhongze Liu wrote: > Add libxl__sshm_del to unmap static shared memory areas mapped by > libxl__sshm_add during domain creation. The unmapping process is: > > * For a master: decrease the refcount of the sshm region, if the refcount > reaches 0, cleanup the whole sshm path. > * For a slave: unmap the shared pages, and cleanup related xs entries. > decrease the refcount of the sshm region, if the refcount reaches 0, > cleanup the whole sshm path. >
This appears to be in line with what we discussed. I would like to see some explanation for: if one or more of the things the code does fail half way, the system is still going to be in a consistent state. Most notably, there isn't going to be any page leaked with uncleaned refs. > + > + rc = libxl__xs_transaction_commit(gc, &xt); > + if (!rc) break; > + if (rc < 0) goto out; > + isretry = true; Indentation. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
