On Fri, Mar 06, 2015 at 06:21:23PM +0100, Dario Faggioli wrote:
> which, if provided, makes the command print a column
> with the name of the cpupool of the listed domain(s).
>
> Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com>
> Cc: Ian Campbell <ian.campb...@citrix.com>
> Cc: Ian Jackson <ian.jack...@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com>
> Cc: Wei Liu <wei.l...@citrix.com>
> Cc: Juergen Gross <jgr...@suse.com>
Acked-by: Wei Liu <wei.l...@citrix.com>
Only one nit. See below.
> - list_domains(verbose, context, 0 /* claim */, numa, info, nb_domain);
> + list_domains(verbose, context, false /* claim */, numa, cpupool,
> + info, nb_domain);
>
> if (info_free)
> libxl_dominfo_list_free(info, nb_domain);
> @@ -6617,7 +6629,7 @@ int main_claims(int argc, char **argv)
> }
>
> list_domains(0 /* verbose */, 0 /* context */, 1 /* claim */,
> - 0 /* numa */, info, nb_domain);
> + 0 /* numa */, 0 /* cpupool */, info, nb_domain);
In previous patch, you changed all types to bool, but you forgot to use
"true" / "false" here.
Wei.
>
> libxl_dominfo_list_free(info, nb_domain);
> return 0;
> diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
> index 22ab63b..9284887 100644
> --- a/tools/libxl/xl_cmdtable.c
> +++ b/tools/libxl/xl_cmdtable.c
> @@ -53,6 +53,7 @@ struct cmd_spec cmd_table[] = {
> "-l, --long Output all VM details\n"
> "-v, --verbose Prints out UUIDs and security context\n"
> "-Z, --context Prints out security context\n"
> + "-c, --cpupool Prints the cpupool the domain is in\n"
> "-n, --numa Prints out NUMA node affinity"
> },
> { "destroy",
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
