On Mon, Oct 30, 2017 at 03:14:04PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v3 for-4.10] scripts: introduce a script for build
> test"):
> > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com>
> > Signed-off-by: Wei Liu <wei.l...@citrix.com>
> ...
> ...
> > +trap "echo Restoring original HEAD ; git checkout $ORIG_BRANCH" EXIT
>
> This will smash the whole script's exit status. I think you need to
> save/restore $?. Be careful with your quoting. Normally it is better
> for the argument to trap to be ''-quoted rather than "", to avoid it
> being expanded twice (and, the first time, too soon).
>
> Also, if this fails, it leaves the failure message buried in a scrool
> of make -j4 output, where the user probably won't see it. And it
> prints exactly the same message on success and failure. On failure
> you should print the failing commitid, and exit nonzero.
>
> On success you should print some reassuring `ok' message.
>
Right. I've addressed your comments and will send out a new version
soon.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
