> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 23 October 2017 13:18 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; Ross > Lagerwall <ross.lagerw...@citrix.com>; Wei Liu <wei.l...@citrix.com>; > Stefano Stabellini <sstabell...@kernel.org>; xen-devel@lists.xen.org; Konrad > Rzeszutek Wilk <konrad.w...@oracle.com>; Tim (Xen.org) <t...@xen.org> > Subject: RE: [Xen-devel] [PATCH v2 2/5] xen: Provide > XEN_DMOP_add_to_physmap > > >>> On 23.10.17 at 14:03, <paul.durr...@citrix.com> wrote: > >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > >> Ross Lagerwall > >> Sent: 23 October 2017 10:05 > >> --- a/xen/include/public/hvm/dm_op.h > >> +++ b/xen/include/public/hvm/dm_op.h > >> @@ -368,6 +368,22 @@ struct xen_dm_op_remote_shutdown { > >> /* (Other reason values are not blocked) */ > >> }; > >> > >> +/* > >> + * XEN_DMOP_add_to_physmap : Sets the GPFNs at which a page range > >> appears in > >> + * the specified guest's pseudophysical address > >> + * space. Identical to XENMEM_add_to_physmap > >> with > >> + * space == XENMAPSPACE_gmfn_range. > >> + */ > >> +#define XEN_DMOP_add_to_physmap 17 > >> + > >> +struct xen_dm_op_add_to_physmap { > >> + uint16_t size; /* Number of GMFNs to process. */ > >> + uint16_t pad0; > >> + uint32_t pad1; > > > > I think you can lose pad1 by putting idx and gpfn above size rather than > > below (since IIRC we only need pad up to the next 4 byte boundary). > > No, tail padding would then still be wanted, I think.
Ok. I stand corrected :-) Paul > > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
