> -----Original Message----- > From: Julien Grall [mailto:julien.gr...@linaro.org] > Sent: 19 October 2017 13:31 > To: Paul Durrant <paul.durr...@citrix.com>; xen-de...@lists.xenproject.org > Cc: Stefano Stabellini <sstabell...@kernel.org>; Wei Liu > <wei.l...@citrix.com>; Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; > George Dunlap <george.dun...@citrix.com>; Andrew Cooper > <andrew.coop...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; Tim > (Xen.org) <t...@xen.org>; Jan Beulich <jbeul...@suse.com> > Subject: Re: [Xen-devel] [PATCH v12 06/11] x86/hvm/ioreq: add a new > mappable resource type... > > Hi, > > On 17/10/17 14:24, Paul Durrant wrote: > > diff --git a/xen/common/memory.c b/xen/common/memory.c > > index cdd2e030cf..b27a71c4f1 100644 > > --- a/xen/common/memory.c > > +++ b/xen/common/memory.c > > @@ -1011,6 +1011,11 @@ static int acquire_resource( > > > > switch ( xmar.type ) > > { > > + case XENMEM_resource_ioreq_server: > > + rc = xenmem_acquire_ioreq_server(d, xmar.id, xmar.frame, > > + xmar.nr_frames, mfn_list); > > + break; > > I fully appreciate you are not able to test on x86. However, I would > have expected you to at least build test it. >
I don't actually know how to set up cross-compilation, which is why I'd originally #ifdef-ed this. > For instance, here you introduced this function on x86, call in common > code but does not introduce it on Arm. > > Although, I don't think we should introduce it for Arm. Instead we > should provide arch helpers as we do for other memory operations. > That would be cleaner in this case. Paul > Cheers, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
