>>> On 19.10.17 at 10:09, <tianyu....@intel.com> wrote: > On 2017年10月18日 23:12, Roger Pau Monné wrote: >> On Thu, Sep 21, 2017 at 11:01:46PM -0400, Lan Tianyu wrote: >>> --- a/tools/libacpi/libacpi.h >>> +++ b/tools/libacpi/libacpi.h >>> @@ -20,6 +20,8 @@ >>> #ifndef __LIBACPI_H__ >>> #define __LIBACPI_H__ >>> >>> +#include <stdbool.h> >> >> I'm quite sure you shouldn't add this here, see how headers are added >> using LIBACPI_STDUTILS. > > We may replace bool with uint8_t xxx:1 to avoid introduce new head file.
Please don't - if you mean boolean, please use bool. Roger's remark, aiui, wasn't about you using bool, but how you do the header inclusion. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
