>>> On 11.10.17 at 05:03, <haozhong.zh...@intel.com> wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1105,7 +1105,13 @@ static void dma_msi_set_affinity(struct irq_desc > *desc, const cpumask_t *mask) > > spin_lock_irqsave(&iommu->register_lock, flags); > dmar_writel(iommu->reg, DMAR_FEDATA_REG, msg.data); > - dmar_writeq(iommu->reg, DMAR_FEADDR_REG, msg.address); > + dmar_writel(iommu->reg, DMAR_FEADDR_REG, msg.address_lo); > + /* > + * When x2APIC is not enabled, DMAR_FEUADDR_REG is reserved and > + * it's not necessary to update it. > + */ > + if (x2apic_enabled)
I'm pretty sure it was pointed out before that the style here is wrong (missing spaces). That's easy to fix while committing, but anyway. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel