>>> On 10.10.17 at 18:47, <george.dun...@citrix.com> wrote: > On 10/10/2017 05:20 PM, George Dunlap wrote: >> Once feof() returns true for a stream, it will continue to return true >> for that stream until clearerr() is called (or the stream is closed >> and re-opened). >> >> In llvm-clang-fast-mode, the same file descriptor is used for each >> iteration of the loop, meaning that the "Input too large" check was >> broken -- feof() would return true even if the fread() hadn't hit the >> end of the file. The result is that AFL generates testcases of >> arbitrary size. >> >> Fix this by fseek'ing to the beginning of the file on every iteration; >> this resets the EOF marker and other state. >> >> Signed-off-by: George Dunlap <george.dun...@citrix.com> >> --- >> Changes in v3: >> - Fix the issue in the official sanctioned way > > Hmm, seems v2 of this patch was checked in; review had flagged up that > "clearerr()" was too big of a hammer.
Oh, I'm sorry for having overlooked that feedback. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
