On Tue, 2015-03-03 at 16:35 +0000, Julien Grall wrote:
> +    gicv3_info.nr_lines = min((unsigned)1020, nr_lines);

"1020U" is the correct way to write (unsigned)1020 I think (in both
places).

Otherwise looks ok, although I had to look twice to figure out that the
register initialisation was the same afterwards.

Where does this value get used? Can you spell it out in the commit log
please.

In particular are you sure that there are no usages which assume this is
a multiple of 32?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Reply via email to