On Tue, 2017-09-26 at 09:24 -0600, Jan Beulich wrote:
> > > > On 15.09.17 at 20:01, <dario.faggi...@citrix.com> wrote:
> > @@ -495,8 +507,18 @@ void rcu_idle_timer_stop()
> >
> > static void rcu_idle_timer_handler(void* data)
> > {
> > - /* Nothing, really... Just count the number of times we fire
> > */
> > perfc_incr(rcu_idle_timer);
> > +
> > + if ( !cpumask_empty(&rcu_ctrlblk.cpumask) )
> > + {
> > + idle_timer_period = min_t(s_time_t, IDLE_TIMER_PERIOD_MAX,
> > + idle_timer_period +
> > IDLE_TIMER_PERIOD_INCR);
> > + }
> > + else
> > + {
> > + idle_timer_period = max_t(s_time_t, IDLE_TIMER_PERIOD_MIN,
> > + idle_timer_period -
> > IDLE_TIMER_PERIOD_DECR);
> > + }
>
> Pointless braces. And do you really need min_t()/max_t() here,
> rather than just min()/max()?
>
I probably can. This must be a leftover from a version when the time of
idle_timer_period, and of the IDLE_TIMER_PERIOD_{MIN,MAX} constants
wasn't matching.Sorry! Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
