>>> On 26.09.17 at 01:08, <bhupinder.tha...@linaro.org> wrote: > Yes, after including the __STRICT_ANSI__ check the headers.chk check > passes. But I had to include string header file (after suggestion from > Stefano) for fixing the headers++.chk.
I'd like to have a more detailed explanation here - since the header passed the check without this prereq before, I'd prefer if the dependency was not added unconditionally. > --- a/xen/include/public/io/console.h > +++ b/xen/include/public/io/console.h > @@ -40,7 +40,9 @@ struct xencons_interface { > XENCONS_RING_IDX out_cons, out_prod; > }; > > +#if defined(__GNUC__) && !defined(__STRICT_ANSI__) > DEFINE_XEN_FLEX_RING(xencons); > +#endif At the first glance it also looks as if the scope of this conditional was too narrow. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel