> -----Original Message----- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: Wednesday, February 11, 2015 10:54 PM > To: Hu, Robert > Cc: xen-devel@lists.xen.org; jfeh...@suse.com; wei.l...@citrix.com; > ian.campb...@citrix.com; Pang, LongtaoX > Subject: Re: [PATCH OSSTEST 05/12] Add and expose some testsupport APIs > > Robert Ho writes ("[PATCH OSSTEST 05/12] Add and expose some testsupport > APIs"): > > When install L2 guest, we will need to invoke 'select_ether' to get > > guest MAC address. So here expose select_ether(). > > I'm not sure whether you actually need to do this. I will look at the rest of > your series to see why prepareguest() isn't suitable. But this part of the > patch > is fine in principle. > > > And > > These seem like two indepenedent patches. They should be split up. > > > also, we added another function 'guest_editconfig_cd' and expose it. > > This function bascically changes guest boot device sequence and > > alter its on_reboot behavior to restart. > > I don't understand why guest_editconfig_nocd isn't sufficient. > After finishing L1 guest VM installation, we need to change L1 guest boot sequence from ISO image to hard disk, so we will edit the "boot=cd" in hvm configure file and we added 'guest_editconfig_cd'. But, guest_editconfig_nocd could not get this point. > Ian.
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
