> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 19 September 2017 10:58 > To: Julien Grall <julien.gr...@arm.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; Paul > Durrant <paul.durr...@citrix.com>; Wei Liu <wei.l...@citrix.com>; > sstabell...@kernel.org; xen-devel@lists.xen.org; Tim (Xen.org) > <t...@xen.org> > Subject: Re: [Xen-devel] [PATCH v2] xen: grant-table: Simplify > get_paged_frame > > >>> On 19.09.17 at 11:39, <julien.gr...@arm.com> wrote: > > On 19/09/17 09:56, Jan Beulich wrote: > >>>>> On 19.09.17 at 10:34, <paul.durr...@citrix.com> wrote: > >>> I do wonder whether this function belongs in the grant table code > though. > >>> Getting the page from a (d, gfn) tuple is probably something that's > needed in > >>> a few places and hence putting the code in common/memory.c (with > suitable > >>> adjustment to the error values) would seem more appropriate. > >> > >> That's been true from the very beginning of the existence of > >> the function, I think. > > > > I am not sure how this function would fit in common/memory.c code. We > > already have get_page_from_gfn to get a page from the tuple (d, gfn). > > > > This function adds more check that may not fit everyone. The only place > > I could see potential usage is prepare_ring_for_helper. But what would > > be a suitable name given? > > Actually I didn't mean to suggest you do anything beyond what > the patch already does. If you, Paul, or anyone else feel like > moving the function, it would probably better be a separate > patch (and we may then want to think of not only a better name, > but also where else such that function may be usable). >
Ok, I'll do it then. I need the same functionality for PV-IOMMU. Paul > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
