>>> On 15.09.17 at 20:48, <ian.jack...@eu.citrix.com> wrote: > SCHEDOP_remote_shutdown should be a DMOP so that a deprivileged qemu > can do the propery tidying up. > > We should remove SCHEDOP_remote_shutdown at some point.
Except we can't for ABI stability reasons, plus how would you remote-shutdown a PV guest then? > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -630,6 +630,14 @@ static int dm_op(const struct dmop_args *op_args) > rc = hvm_inject_msi(d, data->addr, data->data); > break; > } > + case XEN_DMOP_remote_shutdown: With a blank line added above here, and preferably that second sentence of the commit message removed Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel