On Wed, Jun 21, 2017 at 12:59 PM, Jan Beulich <[email protected]> wrote: > I.e. those not being equivalents of SSEn ones. > > There's one necessary change to generic code: Faulting behavior of > VMASKMOVP{S,D} requires us to do partial reads/writes. > > Signed-off-by: Jan Beulich <[email protected]>
Having dug a bit through the manuals about AVX, then come back to this patch again, I feel the same way that I did when I first read it: This discription is woefully inadequate. It doesn't look so much like a changelog as a note to yourself. If someone else sent a patch description like this for a patch this complicated and expected you to review it you'd certainly complain, and there's a good chance you wouldn't review it. It's not your job to teach me how this code is laid out and how it works, but there at least needs to be enough description of what the patch is actually trying to do that I have some hope of reconstructing its intent. -George _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
