On Mon, 2015-01-19 at 16:28 +0800, Chunyan Liu wrote:
> Add code to support pvusb from domain create. One could specify
> usb in domain's configuration file and create domain, then usb
> device would be attached to guest automatically.
>
> One could specify usb device in config file like this:
> usb=['2-1.1']
>
> Signed-off-by: Chunyan Liu <cy...@suse.com>
> Signed-off-by: Simon Cao <caobosi...@gmail.com>
> ---
> tools/libxl/libxl_create.c | 41 ++++++++++++++++++++++++++++++++++++++---
> tools/libxl/xl_cmdimpl.c | 40 +++++++++++++++++++++++++++++++++++++++-
This should be touching the docs too.
> +static void domcreate_attach_usbs(libxl__egc *egc, libxl__multidev *multidev,
> + int ret)
> +{
> [...]
> + for (i = 0; i < d_config->num_usbs; i++) {
> + ret = libxl__device_usb_add(gc, domid, &d_config->usbs[i]);
> + if (ret < 0) {
> + LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
> + "libxl__device_usb_add failed: %d", ret);
Use the LOG*( macros please.
Otherwise the code looks fine, only the lack of docs stops me acking.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
