On Thu, Aug 31, 2017 at 10:35:57AM +0100, Paul Durrant wrote: > By using a static inline stub in private.h for OS where this functionality > is not implemented, the various duplicate stubs in the OS-specific source > modules can be avoided.
Ouch, forget my comment in the previous patch, haven't seen that one. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > --- > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> > > v3: > - Patch added in response to review comments. > --- > tools/libs/foreignmemory/minios.c | 7 ------- > tools/libs/foreignmemory/netbsd.c | 7 ------- > tools/libs/foreignmemory/private.h | 12 +++++++++--- > tools/libs/foreignmemory/solaris.c | 7 ------- You forgot the one in freebsd.c. With that added (or rather removed): Reviewed-by: Roger Pau Monné <roger....@citrix.com> Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
