>>> On 29.08.17 at 17:57, <andrew.coop...@citrix.com> wrote: > Switch the return value from int to bool, to match its semantics. Switch its > parameter from a frame offset to a byte offset (simplifying the sole caller) > and allowing for an extra sanity check that the fault is within the LDT > limit. > > Drop the unnecessary gmfn and okay local variables, and correct the gva > parameter to be named linear. Rename l1e to gl1e, and simplify the > construction of the new pte by simply taking (the now validated) gl1e and > ensuring that _PAGE_RW is set. > > Calculate the pte to be updated outside of the spinlock, which halves the size > of the critical region. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <wei.l...@citrix.com> > > v2: > * Adjustments to various comments.
Thanks! Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
