On 08/28/2017 10:52 AM, Jan Beulich wrote: >>>> On 28.08.17 at 16:24, <boris.ostrov...@oracle.com> wrote: >>>> As for periodically testing process_pending_softirqs() we may still want >>>> to do this in alloc_heap_pages(), even without CONFIG_SCRUB_DEBUG. >>> For my taste, alloc_heap_pages() is the wrong place for such >>> calls. >> But the loop is in alloc_heap_pages() --- where else would you be testing? > It can only reasonably be the callers of alloc_heap_pages() imo. > A single call to it should never trigger the watchdog,
check_one_page() is rather slow so for a large order allocation even with clean heap the 'for' loop may take quite some time. Whether it could trip the watchdog -- I don't know. -boris > only calls > themselves sitting in a loop should be potential candidates for > causing such. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
