On Mon, 2015-03-02 at 14:31 +0000, Wei Liu wrote: > On Mon, Mar 02, 2015 at 02:20:57PM +0000, Ian Campbell wrote: > > On Mon, 2015-03-02 at 10:52 +0000, Wei Liu wrote: > > > OVMF's distclean target was missed in f9c9b1277 (tools: fix "make > > > distclean"). > > > > tools/firmware/Makefile has: > > subdir-distclean-ovmf: .phony > > rm -rf ovmf-dir ovmf-dir-remote > > > > Shouldn't this be avoiding recursing into ovmf-dir in the first place? > > > > Or is there some other reason to want this? > > > > If you're in firmware directory and do "make distclean", make will > recurse into ovmf to do "make distclean".
Really? Despite the rule I quoted above? How strange, I wonder why that is. I'd have expected "make distclean" to behave the same whether run in the directory or recursed into frmo a higher level. > > Wei. > > > > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > > Cc: Anthony Perard <anthony.per...@citrix.com> > > > Cc: Ian Campbell <ian.campb...@citrix.com> > > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > > > --- > > > tools/firmware/ovmf-makefile | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile > > > index 2838744..c922d4d 100644 > > > --- a/tools/firmware/ovmf-makefile > > > +++ b/tools/firmware/ovmf-makefile > > > @@ -22,3 +22,6 @@ build: > > > .PHONY: clean > > > clean: > > > rm -rf ovmf.bin Build/* > > > + > > > +.PHONY: distclean > > > +distclean: clean > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
