On 08/23/2017 03:10 PM, Andre Przywara wrote:
Hi,
Hi,
On 14/08/17 15:24, Julien Grall wrote:
This will help to consolidate the page-table code and avoid different
path depending on the action to perform.
Signed-off-by: Julien Grall <julien.gr...@arm.com>
It could be worth to mention in the commit message that the removed
ASSERT is now already cared for in create_xen_entries() (which is also
another hint to make that an ASSERT, actually).
If you look at the code modify_xen_mappings is using the operation
MODIFY which already had a permission check without this series.
But this ASSERT here does not do what you think. It only check that the
flags PTE_NX and PTE_RO could be set, not the mapping is non-executable
and writeable.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
