>>> On 14.08.17 at 16:23, <julien.gr...@arm.com> wrote: > The only way alloc_boot_pages will return 0 is during the error case. > Although, Xen will panic in the error path. So the check in the caller > is pointless. > > Looking at the loop, my understanding is it will try to allocate in > smaller chunk if a bigger chunk fail. Given that alloc_boot_pages can > never check, the loop seems unecessary.
Long, long ago alloc_boot_pages() could return 0 without panic()-ing or BUG()-ing. > Signed-off-by: Julien Grall <julien.gr...@arm.com> This as well as the earlier two patches Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel