On 15/08/17 14:49, Jan Beulich wrote:
> @@ -2608,7 +2610,7 @@ static long gnttab_copy(
> {
> if ( i && hypercall_preempt_check() )
> {
> - rc = i;
> + rc = count - i;
Somewhere, probably as a comment for gnttab_copy(), we should have a
comment explaining why the return value is different from all other ops,
which will also go somewhat to explaining the "rc = count - rc;" logic.
I think it would also be wise to have an early exit in
do_grant_table_op() for passing a count of 0. As far as I can tell, we
will get all the way into the subop handler before discovering a count of 0.
Otherwise, LGTM.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
