On 27/02/15 16:51, Wei Liu wrote: > On Fri, Feb 27, 2015 at 04:42:42PM +0000, Jan Beulich wrote: >>>>> On 26.02.15 at 16:55, <wei.l...@citrix.com> wrote: >>> Update NUMA_NO_NODE in Xen code to use the new macro. >>> >>> No functional change introduced. >> But also no explanation given why this is being done. After all just >> leaving out the explicit specification on a node in the memop flags >> has the effect of saying NUMA_NO_NODE. >> > During last round review, Andrew wanted me to move this to Xen public > header to avoid reinventing it in libxc. Now this value is used in libxc > patch. > > But I don't particularly mind whether we move it or not, it's up to you > maintainers to decide.
It is a sentinel value used in the public ABI. It should therefore appear in the public API. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel