Hi Ian, On 20/02/15 17:09, Julien Grall wrote: > On 20/02/15 15:52, Ian Campbell wrote: >>> >>> action = xmalloc(struct irqaction); >>> - if (!action) >>> + if ( !action ) >>> + return -ENOMEM; >>> + >>> + info = xmalloc(struct irq_guest); >> >> FWIW you might (subject to sizing/alignment needs) be able to do >> action = _xmalloc(sizeof(struct irqaction) + sizeof(struct irq_guest); >> info = (sturct irq_guest *)(action + 1); >> >> which would save some memory overhead for free pointers etc and allow >> you to avoid manually managing the info. >> >> You probably won't like that though, so feel free to ignore. > > Actually it's a good idea :). I haven't though about it.
I though about it. The pointer to irq_guest may not be correctly aligned with this solution, right? So I prefer to keep separate the allocation. We can revisit it later. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
