On Tue, 2017-08-08 at 12:06 -0700, Meng Xu wrote: > On Tue, Aug 8, 2017 at 10:57 AM, Dario Faggioli > <[email protected]> wrote: > > On Sun, 2017-08-06 at 12:22 -0400, Meng Xu wrote: > > > > > > diff --git a/xen/include/public/domctl.h > > > b/xen/include/public/domctl.h > > > index 0669c31..ba5daa9 100644 > > > --- a/xen/include/public/domctl.h > > > +++ b/xen/include/public/domctl.h > > > @@ -360,6 +360,9 @@ typedef struct xen_domctl_sched_credit2 { > > > typedef struct xen_domctl_sched_rtds { > > > uint32_t period; > > > uint32_t budget; > > > +#define _XEN_DOMCTL_SCHED_RTDS_extratime 0 > > > +#define > > > XEN_DOMCTL_SCHED_RTDS_extratime (1U<<_XEN_DOMCTL_SCHED_RTDS_extr > > > atim > > > e) > > > + uint32_t flags; > > > > > > > I'd add a one liner comment above the flag definition, as, for > > instance, how things are done in createdomain: > > Sure. > > How about comment: > /* Does this VCPU get extratime beyond reserved time? */ > 'Can this vCPU execute beyond its reserved amount of time?'
> >
> > struct xen_domctl_createdomain {
> > /* IN parameters */
> > uint32_t ssidref;
> > xen_domain_handle_t handle;
> > /* Is this an HVM guest (as opposed to a PVH or PV guest)? */
> > #define _XEN_DOMCTL_CDF_hvm_guest 0
> > #define
> > XEN_DOMCTL_CDF_hvm_guest (1U<<_XEN_DOMCTL_CDF_hvm_guest)
> > /* Use hardware-assisted paging if available? */
> > #define _XEN_DOMCTL_CDF_hap 1
> > #define XEN_DOMCTL_CDF_hap (1U<<_XEN_DOMCTL_CDF_hap)
> >
> > Also, consider shortening the name (e.g., by contracting the
> > SCHED_RTDS
> > part; it does not matter if it's not 100% equal to what's in
> > sched_rt.c, I think).
>
>
> How about shorten it to XEN_DOMCTL_RTDS_extra or
> XEN_DOMCTL_RTDS_extratime?
>
Personally, I'd go for XEN_DOMCTL_SCHEDRT_extra (or _extratime, or
_extrat).
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
