On 03/08/17 13:31, Oleksandr Tyshchenko wrote:
Hi, Julien

On Thu, Aug 3, 2017 at 2:33 PM, Julien Grall <julien.gr...@arm.com> wrote:
Hi Oleksandr,

On 25/07/17 18:26, Oleksandr Tyshchenko wrote:

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index ec19310..3079bbe 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -569,7 +569,7 @@ int arch_domain_create(struct domain *d, unsigned int
domcr_flags,
     ASSERT(config != NULL);

     /* p2m_init relies on some value initialized by the IOMMU subsystem
*/
-    if ( (rc = iommu_domain_init(d, false)) != 0 )
+    if ( (rc = iommu_domain_init(d, !!config->use_iommu)) != 0 )


NIT: !! is not necessary as the parameter is a bool :).
Shall I drop "!!"?

Yes please.



Acked-by: Julien Grall <julien.gr...@arm.com>
Thank you!


         goto fail;

     if ( (rc = p2m_init(d)) != 0 )


Cheers,

--
Julien Grall




--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Reply via email to