>>> Wei Liu <wei.l...@citrix.com> 07/18/17 5:30 PM >>> >On Tue, Jul 18, 2017 at 05:11:23PM +0530, vijay.kil...@gmail.com wrote: >> --- a/xen/arch/Kconfig >> +++ b/xen/arch/Kconfig >> @@ -6,3 +6,10 @@ config NR_CPUS >> default "128" if ARM >> ---help--- >> Specifies the maximum number of physical CPUs which Xen will support. >> + >> +config NR_NODES >> + int "Maximum number of NUMA nodes" >> + default "64" if X86 >> + default "8" if ARM >> + ---help--- >> + Specifies the maximum number of NUMA nodes which Xen will support. > >Since this can now be specified by user but the definition of >NUMA_NO_NODE is not changed, I think you need to sanitise the value >provided somewhere. > >Maybe introduce a build time check? There are some examples in tree. See >cpuid.c:build_assertions.
I think the option above should obtain a "range" line, at once excluding non- positive values. A BUILD_BUG_ON() would then still be desirable, though. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
