On Thu, 20 Jul 2017, Julien Grall wrote:
> Hi Vijay,
>
> On 18/07/17 12:41, vijay.kil...@gmail.com wrote:
> > From: Vijaya Kumar K <vijaya.ku...@cavium.com>
> >
> > Move code from xen/arch/x86/srat.c to xen/common/numa.c
> > so that it can be used by other archs.
> >
> > Apart from moving the code the following changes are done
> > - Coding style of code moved to numa.c is changed to xen style
> > - {memory,processor}_nodes_parsed are made global and moved
> > to xen/nodemask.h
> > - Few generic static functions in x86/srat.c are made
> > non-static
> > - Functions moved from x85/srat.c to common/numa.c are made
> > non-static
> > - numa_scan_nodes() is made as static function
> > - compute_memnode_shift() and setup_node_bootmem() are made
> > static.
>
> You modify the coding style at the same time as the same time as moving the
> code. This makes quite difficult to make sure that a mistake didn't slip in
> the new code. Can you please diving this patch in smaller chunk (i.e moving
> code in smaller chunk) to ease the review?
For your reference and my own, the code movement in this patch is
correct. Splitting it would be good of course.
> We can think of merging all of them when committing it.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
