On 24/07/17 15:44, Wei Liu wrote: > On Mon, Jul 24, 2017 at 03:25:22PM +0100, Andrew Cooper wrote: >> On 24/07/17 15:02, Wei Liu wrote: >>> Wei Liu (3): >>> x86: nuke PV superpage option and code >>> tools: nuke superpage parameters in code >>> docs: delete PV superpage option >> If you are doing this, can you modify >> xc_sr_save_x86_pv.c:normalise_pagetable() to fail immediately if a >> superpage is found. Currently, this condition is deferred until the >> live phase is complete. >> > Why was it done like that in the first place?
Because if a PV guest shatters all of its superpages during the live phase, it can be successfully moved. This work was mixed up in the question of the time as to whether PV migraiton worked with superpages at all, seeing as the legacy code took a (non-working) stab at attempting the migration. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
