>>> On 06.07.17 at 13:50, <prosku...@sec.in.tum.de> wrote: > --- /dev/null > +++ b/xen/include/xen/page-defs.h > @@ -0,0 +1,24 @@ > +#ifndef __XEN_PAGE_DEFS_H__ > +#define __XEN_PAGE_DEFS_H__ > + > +/* Helpers for different page granularities. */ > +#define PAGE_SIZE_GRAN(gran) (1UL << PAGE_SHIFT_##gran) > +#define PAGE_MASK_GRAN(gran) (~(0ULL) << PAGE_SHIFT_##gran)
Stray parentheses. I'm also unhappy about the type difference between size and mask. I guess both would best be paddr_t. That'll then also allow mask to be defined as -size. Another alternative would be to use 1L for size, thus guaranteeing suitable sign extension when used in contexts requiring a width wider than long. > +#define PAGE_ALIGN_GRAN(gran, addr) (((addr) + ~PAGE_MASK_##gran) & > PAGE_MASK_##gran) > + > +#define PAGE_SHIFT_4K (12) Stray parentheses again. Also, with you adding a new header that'll fall under REST maintainership, you should have Cc-ed all the REST maintainers imo. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
